Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTable block: use only restaurant IDs and remove searching for name #41162

Merged
merged 5 commits into from
Mar 18, 2025
Merged

OpenTable block: use only restaurant IDs and remove searching for name #41162

merged 5 commits into from
Mar 18, 2025

Conversation

draganescu
Copy link
Contributor

@draganescu draganescu commented Jan 17, 2025 •
edited
Loading

Fixes #39410

Proposed changes:

  • Remove the search feature because the OpenTable API does not support it anymore

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • In a new page
  • Add an open table block
  • Use these ids 343654, 173589
  • Notice the embed works
  • Add another open table block
  • Try to search or a restaurant name
  • Notice there is no error

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/open-table-picker branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/open-table-picker

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] OpenTable [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: April 1, 2025
    • Code freeze: March 30, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 17, 2025
@draganescu draganescu added [Type] Bug When a feature is broken and / or not performing as intended and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jan 17, 2025
@draganescu draganescu self-assigned this Jan 17, 2025
@draganescu draganescu marked this pull request as ready for review January 17, 2025 17:47
jeherve
jeherve previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. I have some remarks, but not blockers:

I wonder if we should update the title of this panel to mention "ids"?
image

I also noticed some alignment issues, maybe we could take that opportunity to fix that?

image

Maybe in a future PR we could improve the error handling when you paste an incorrect / invalid restaurant widget. Right now we display no error messages at all.

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Pri] Normal and removed [Status] In Progress labels Jan 24, 2025
fushar
fushar reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it does not seem to work if we only provide 1 restaurant ID. Not sure how it's supposed to work 🤔

image

@fushar
Copy link
Contributor

fushar commented Jan 31, 2025

^ Hmm, it seems to be a production behavior though 🤔

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/blocks/opentable/restaurant-picker.js 0/19 (0.00%) 0.00% -2 💚

Full summary · PHP report · JS report

@fushar
Copy link
Contributor

fushar commented Jan 31, 2025

I wonder if we should update the title of this panel to mention "ids"?

I also noticed some alignment issues, maybe we could take that opportunity to fix that?

These have been addressed 👍

@fushar fushar changed the title Use only restaurant ID and remove searching for name OpenTable block: use only restaurant IDs and remove searching for name Jan 31, 2025
fushar
fushar previously approved these changes Jan 31, 2025
View reviewed changes
@draganescu
Copy link
Contributor Author

Howdy @fushar thanks for lending a hand here! This is great, I'll merge this as soon as I do a rebase.

@draganescu draganescu force-pushed the fix/open-table-picker branch from 5231f5d to 9980260 Compare March 18, 2025 10:33
@jp-launch-control JP Launch Control
Copy link

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/blocks/opentable/restaurant-picker.js 0/19 (0.00%) 0.00% -2 💚

Full summary · PHP report · JS report

@draganescu draganescu merged commit 456da67 into trunk Mar 18, 2025
65 checks passed
@draganescu draganescu deleted the fix/open-table-picker branch March 18, 2025 11:48
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 18, 2025
@github-actions github-actions bot added this to the jetpack/14.5 milestone Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fushar fushar fushar approved these changes

@jeherve jeherve jeherve left review comments

Assignees

@draganescu draganescu

Labels
[Block] OpenTable [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
jetpack/14.5
Development

Successfully merging this pull request may close these issues.

OpenTable Reservation block calls are inconsistent
3 participants
@draganescu @fushar @jeherve